WRR-9115: Scroller: Fixed to focus properly when the spottable node is bigger than the viewport by scrolling with voice control
#1748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…han the viewport by scrolling with voice control Enact-DCO-1.0-Signed-off-by: Hyelyn Kim ([email protected])
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1748 +/- ##
========================================
Coverage 80.89% 80.89%
========================================
Files 148 148
Lines 6672 6672
Branches 1988 1988
========================================
Hits 5397 5397
Misses 967 967
Partials 308 308 ☔ View full report in Codecov by Sentry. |
Enact-DCO-1.0-Signed-off-by: Juwon Jeong ([email protected])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
When scrolling down with voice control in certain apps, focus is not restored.
Currently, when scrolling with voice control, focus is moved only when the bounds of the viewport include all bounds of the node.
Therefore, it is necessary to handle the case where the node's bounds are not all included in the viewport's bounds.
(when there is a large node that goes out of bounds, the upper part is visible but the lower part is cut off, etc.)
Resolution
Added focus logic for cases where the top of the node is long and the bottom of the node is long using node Bounds and viewports Bounds. Since I need to receive and check new nodes, I implemented it using a recursive function.
Additional Considerations
Links
WRR-9115
Comments
Enact-DCO-1.0-Signed-off-by: Hyelyn Kim ([email protected])